Skip to content

[Forwardport] Refactory to Magento_Backend module class.#17102

Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
tiagosampaio:2.3-develop-009
Aug 11, 2018
Merged

[Forwardport] Refactory to Magento_Backend module class.#17102
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
tiagosampaio:2.3-develop-009

Conversation

@tiagosampaio
Copy link
Copy Markdown
Member

@tiagosampaio tiagosampaio commented Jul 24, 2018 •
edited by sidolov
Loading

Refactory of a class in Magento_Backend module.

Description

Simple refactory to Magento_Backend module class.

  • Turning protected properties into private ones.
  • Using dependency injection rather than using Object Manager directly.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR:

#17101

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jul 24, 2018

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev ihor-sviziev self-assigned this Jul 25, 2018
@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Jul 25, 2018

FYI It's better to create up ports just after your PR was merged because original PR might contains some additional fixes and you have to add them. Also forward ports might be easy created by special tool (only when original PR was merged): https://github.com/magento/magento2/wiki/Simple-way-to-port-your-solutions-automatically

@ihor-sviziev ihor-sviziev changed the title [Up Port 2.3] Refactory to Magento_Backend module class. [Forwardport] Refactory to Magento_Backend module class. Aug 7, 2018
@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Aug 7, 2018

Hi @tiagosampaio,
Please cherry-pick following commit 9ff8983

@tiagosampaio
Copy link
Copy Markdown
Member Author

tiagosampaio commented Aug 7, 2018 •
edited
Loading

Hi @ihor-sviziev. I had to cherry-pick the commit a1339ba before yours.

That should be fine now.

Thanks.

@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Aug 8, 2018

@tiagosampaio thx, will review this PR just when original PR will be merged

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 8, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 8, 2018

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2714 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit fb65e2f into magento:2.3-develop Aug 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 11, 2018
ENGCOM-2714: [Forwardport] Refactory to Magento_Backend module class. #…
f76ff32 
…17102
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 11, 2018

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels

Component: Backend Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tiagosampaio @magento-engcom-team @ihor-sviziev